curtin-dev team mailing list archive

[Paride Legovini <paride.legovini@xxxxxxxxxxxxx>]

Review: Needs Information

I went through the code and it looks good, I'd just clarify a bit more the reason why we want to keep the current boot entry the first one (see inline comment). Take it as a "nit" comment: up to you to decide if it's worth fixing or not.

Just to be sure: this is the code that Rod validated in LP: #1789650 using your PPA, correct?  While the code looks good and CI passes with the new tests it's not immediate to test it in practice.

Diff comments:

> diff --git a/doc/topics/config.rst b/doc/topics/config.rst
> index 7f8396e..9afa220 100644
> --- a/doc/topics/config.rst
> +++ b/doc/topics/config.rst
> @@ -226,6 +226,31 @@ not provided, Curtin will set the value to 'console'.  If the ``terminal``
>  value is 'unmodified' then Curtin will not set any value at all and will
>  use Grub defaults.
>  
> +**reorder_uefi**: *<boolean: default True>*
> +
> +On UEFI systems curtin will modify the UEFI BootOrder settings to place
> +the currently booted entry (BootCurrent) to the first option after installing
> +the new target OS into the UEFI boot menu.  The result is that the system
> +will boot from the same device that it booted to run curtin.

At first glance the reason for this is not obvious: don't we want to boot the *installed* system after installing and rebooting? I think it's worth adding one more sentence to explain the rationale of the reordering.

> +
> +On some UEFI systems the BootCurrent entry may not be present.  This can
> +cause a system to not boot to the same device that it was previously booting.
> +If BootCurrent is not present, curtin will update the BootOrder such that
> +all Network related entries are placed before the newly installed boot entry and
> +all other entries are placed at the end.  This enables the system to network
> +boot first and on failure will boot the most recently installed entry.
> +
> +This setting is ignored if *update_nvram* is False.
> +
> +
> +**reorder_uefi_force_fallback**: *<boolean: default False>*
> +
> +The fallback reodering mechanism is only active if BootCurrent is not present
> +in the efibootmgr output.  The fallback reordering method may be enabled
> +even if BootCurrent is present if *reorder_uefi_force_fallback* is True.
> +
> +This setting is ignored if *update_nvram* or *reorder_uefi* are False.
> +
>  
>  **Example**::
>  


-- 
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/387981
Your team curtin developers is subscribed to branch curtin:master.