curtin-dev team mailing list archive

Thread
Date

Re: [Merge] ~raharper/curtin:fix/20200908-fix-vmtest-master into curtin:master

To: mp+390491@xxxxxxxxxxxxxxxxxx
From: Paride Legovini <paride.legovini@xxxxxxxxxxxxx>
Date: Thu, 10 Sep 2020 10:10:12 -0000
In-reply-to: <159967109397.19910.13623537674722427685.codereview@gac.canonical.com>
Reply-to: mp+390491@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

Hi Ryan, thanks for this!

We probably don't need one MP per change, given that most of them have a very clear scope.

What about taking out:

1e4d0243aa2375b0a48360b0e54af75c71b63ddd
479be299a446d1afd270e5a33741146ded5d9a70

as separate MPs and combine the other changes in a single MP to be squashed by CI?
-- 
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/390491
Your team curtin developers is subscribed to branch curtin:master.

References

Re: [Merge] ~raharper/curtin:fix/20200908-fix-vmtest-master into curtin:master
From: Ryan Harper, 2020-09-09