curtin-dev team mailing list archive

[Ryan Harper <rharper@xxxxxxxxxxx>]

Review: Needs Fixing

One suggestion in line.

Diff comments:

> diff --git a/curtin/block/mdadm.py b/curtin/block/mdadm.py
> index 32b467c..9c1d54a 100644
> --- a/curtin/block/mdadm.py
> +++ b/curtin/block/mdadm.py
> @@ -837,4 +850,8 @@ def md_check(md_devname, raidlevel, devices=[], spares=[]):
>      LOG.debug('RAID array OK: ' + md_devname)
>      return True
>  
> +def md_is_container(md_devname):
> +    md_query = mdadm_query_detail(md_devname)
> +    return md_query.get('MD_CONTAINER', None)

Typically an _is_a would return a boolean, so let's:

def md_is_container(md_devname):
   return 'MD_CONTAINER' in mdadm_query_detail(md_devname)

> +
>  # vi: ts=4 expandtab syntax=python


-- 
https://code.launchpad.net/~gyurco/curtin/+git/curtin/+merge/390307
Your team curtin developers is requested to review the proposed merge of ~gyurco/curtin:imsm into curtin:master.