curtin-dev team mailing list archive

[Paride Legovini <paride.legovini@xxxxxxxxxxxxx>]

Review: Needs Fixing

Thanks Ryan! I didn't realize that ascii-armoured keys were not supported in Xenial.

We should try not to use apt-key, see LP: #1836336. Dropping the dearmoured key in trusted.gpg.d works on Xenial (tested). I suggest doing:

-local kfile="/etc/apt/trusted.gpg.d/curtin-daily-ppa.asc"
+local kfile="/etc/apt/trusted.gpg.d/curtin-daily-ppa.gpg"

- wget -q \"$keyurl\" -O $kfile" ||
+ curl -sS \"$keyurl\" | gpg --dearmour --output $kfile ||

Excuse the human generated pseudo-diff :)

I prefer curl for noninteractive download operations in scripts, especially if output to stdout is desired. curtainer makes no other use of wget or curl. curl is available in the xenial-minimal and groovy-minimal images. Feel free to keep wget if you prefer.



-- 
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/391842
Your team curtin developers is subscribed to branch curtin:master.