curtin-dev team mailing list archive
-
curtin-dev team
-
Mailing list archive
-
Message #00970
[Merge] ~paride/curtin:deb-rules-drop-pkgversion into curtin:master
Paride Legovini has proposed merging ~paride/curtin:deb-rules-drop-pkgversion into curtin:master.
Commit message:
debian/rules: drop PKG_VERSION (unused and broken)
The PKG_VERSION variable in debian/rules is not used and the command
generating it doesn't work, generating a 'Bad substitution' error at
every build.
(The problem is with the '\#\#' escape, which is not needed.)
Requested reviews:
curtin developers (curtin-dev)
For more details, see:
https://code.launchpad.net/~paride/curtin/+git/curtin/+merge/392370
--
Your team curtin developers is requested to review the proposed merge of ~paride/curtin:deb-rules-drop-pkgversion into curtin:master.
diff --git a/debian/rules b/debian/rules
index 74be87c..6b99eb4 100755
--- a/debian/rules
+++ b/debian/rules
@@ -4,7 +4,6 @@ PY3VERS := $(shell py3versions -r)
DEB_VERSION := $(shell dpkg-parsechangelog --show-field=Version)
UPSTREAM_VERSION := $(shell x="$(DEB_VERSION)"; echo "$${x%-*}")
-PKG_VERSION := $(shell x="$(DEB_VERSION)"; echo "$${x\#\#*-}")
%:
dh $@ --with=python3
Follow ups
-
[Merge] ~paride/curtin:deb-rules-drop-pkgversion into curtin:master
From: Server Team CI bot, 2020-10-19
-
Re: [Merge] ~paride/curtin:deb-rules-drop-pkgversion into curtin:master
From: Server Team CI bot, 2020-10-19
-
Re: [Merge] ~paride/curtin:deb-rules-drop-pkgversion into curtin:master
From: Server Team CI bot, 2020-10-19
-
[Merge] ~paride/curtin:deb-rules-drop-pkgversion into curtin:master
From: Chad Smith, 2020-10-19
-
Re: [Merge] ~paride/curtin:deb-rules-drop-pkgversion into curtin:master
From: Chad Smith, 2020-10-19
-
[Merge] ~paride/curtin:deb-rules-drop-pkgversion into curtin:master
From: Paride Legovini, 2020-10-19
-
Re: [Merge] ~paride/curtin:deb-rules-drop-pkgversion into curtin:master
From: Server Team CI bot, 2020-10-19
-
Re: [Merge] ~paride/curtin:deb-rules-drop-pkgversion into curtin:master
From: Paride Legovini, 2020-10-19
-
[Merge] ~paride/curtin:deb-rules-drop-pkgversion into curtin:master
From: Paride Legovini, 2020-10-19
-
Re: [Merge] ~paride/curtin:deb-rules-drop-pkgversion into curtin:master
From: Chad Smith, 2020-10-19
-
Re: [Merge] ~paride/curtin:deb-rules-drop-pkgversion into curtin:master
From: Server Team CI bot, 2020-10-16