curtin-dev team mailing list archive

[Michael Hudson-Doyle <mwhudsonlp@xxxxxxxxxxx>]

Michael Hudson-Doyle has proposed merging ~mwhudson/curtin:no-dasds-in-get_path_to_storage_volume into curtin:master.

Commit message:
remove support for calling get_path_to_storage_volume on a dasd action

there is no code path that will do this today, and this implementation
will not work with some changes I want to make to support dasds passed
via virtio.


Requested reviews:
  curtin developers (curtin-dev)

For more details, see:
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/393794
-- 
Your team curtin developers is requested to review the proposed merge of ~mwhudson/curtin:no-dasds-in-get_path_to_storage_volume into curtin:master.

diff --git a/curtin/commands/block_meta.py b/curtin/commands/block_meta.py
index 30fc817..eada650 100644
--- a/curtin/commands/block_meta.py
+++ b/curtin/commands/block_meta.py
@@ -437,10 +437,6 @@ def get_path_to_storage_volume(volume, storage_config):
             volume_path = block.kname_to_path(partition_kname)
         devsync_vol = os.path.join(disk_block_path)
 
-    elif vol.get('type') == "dasd":
-        dasd_device = dasd.DasdDevice(vol.get('device_id'))
-        volume_path = dasd_device.devname
-
     elif vol.get('type') == "disk":
         # Get path to block device for disk. Device_id param should refer
         # to id of device in storage config