curtin-dev team mailing list archive

[Ryan Harper <rharper@xxxxxxxxxxx>]

Do we have a reuse existing mpath with partitions in vmtest?  If not, that'd be a good thing to add.

Diff comments:

> diff --git a/curtin/storage_config.py b/curtin/storage_config.py
> index e6c33cc..81b7385 100644
> --- a/curtin/storage_config.py
> +++ b/curtin/storage_config.py
> @@ -681,10 +622,15 @@ class BlockdevParser(ProbertParser):
>          errors = []
>  
>          for devname, data in self.blockdev_data.items():
> -            # skip composed devices here, except partitions
> +            # skip composed devices here, except partitions and multipath
>              if data.get('DEVPATH', '').startswith('/devices/virtual/block'):
> -                if data.get('DEVTYPE', '') != "partition":
> -                    continue
> +                if not self.is_mpath_device(data):
> +                    if not self.is_mpath_partition(data):
> +                        if data.get('DEVTYPE', '') != "partition":
> +                            continue

Oh, one thing to check, do partitions on bcache have DEVTYPE 'partition' ?  I realized that we do have a bcache partition vmtest, but I've not pulled in the probert data on such an instance.  There was a version of openstack ceph which partitioned bcached devices.

> +            # skip disks that are members of multipath devices
> +            if self.is_mpath_member(data):
> +                continue
>              entry = self.asdict(data)
>              if entry:
>                  try:


-- 
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/392353
Your team curtin developers is subscribed to branch curtin:master.