← Back to team overview

curtin-dev team mailing list archive

[Merge] ~paride/curtin:pylint-explicit-generated-members into curtin:master

 

The proposal to merge ~paride/curtin:pylint-explicit-generated-members into curtin:master has been updated.

Commit message changed to:

pylintrc: explicitly list the DISTROS generated-members

For some obscure reason setting

  generated-members=DISTROS\.

in pylintrc makes the pylint run flaky, causing failures like:

curtin/commands/install_grub.py:93:19:
  E1101: Instance of 'Distros' has no 'debian' member (no-member)
curtin/commands/install_grub.py:155:28:
  E1101: Instance of 'Distros' has no 'redhat' member (no-member)

These failures:

 - happen on about 15% of the time, at least on Bionic
 - also happen with the latest stable version of pylint (2.8.2)
 - only happen on install_grub.py (which only refers to debian and redhat)
 - do not seem to happen on Impish.
 - possibly related: https://github.com/PyCQA/pylint/issues/1628

But the truth is I don't understand why generated-members=DISTROS\.
even works some of the time for some generated members. Let's replace
it with the explicit list of the (non auto-detected) generated members,
so it will always work, and we'll know why it does.

For more details, see:
https://code.launchpad.net/~paride/curtin/+git/curtin/+merge/402652
-- 
Your team curtin developers is subscribed to branch curtin:master.


References