curtin-dev team mailing list archive

[Michael Hudson-Doyle <mp+406826@xxxxxxxxxxxxxxxxxx>]

Review: Approve

Looks fine, a couple of lines that can be deleted I think. Have you run the vmtests that you are adding for focal?

Diff comments:

> diff --git a/tests/vmtests/test_network_vlan.py b/tests/vmtests/test_network_vlan.py
> index af52af0..1f78cfa 100644
> --- a/tests/vmtests/test_network_vlan.py
> +++ b/tests/vmtests/test_network_vlan.py
> @@ -90,9 +90,12 @@ class HirsuteTestNetworkVlan(relbase.hirsute, TestNetworkVlanAbs):
>          return super().test_ip_output()
>  
>  
> -class GroovyTestNetworkVlan(relbase.groovy, TestNetworkVlanAbs):
> +class ImpishTestNetworkVlan(relbase.impish, TestNetworkVlanAbs):
>      __test__ = True
>  
> +    def test_ip_output(self):

I don't know what's going on here but this seems pointless.

> +        return super().test_ip_output()
> +
>  
>  class Centos66TestNetworkVlan(centos_relbase.centos66_xenial,
>                                CentosTestNetworkVlanAbs):


-- 
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/406826
Your team curtin developers is subscribed to branch curtin:master.