curtin-dev team mailing list archive

[Dan Bungert <mp+407568@xxxxxxxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> diff --git a/curtin/block/lvm.py b/curtin/block/lvm.py
> index bd0f1aa..333b46f 100644
> --- a/curtin/block/lvm.py
> +++ b/curtin/block/lvm.py
> @@ -126,8 +128,9 @@ def lvm_scan(activate=True, multipath=False):
>          release = 'xenial'
>  
>      if multipath:
> -        # only operate on mp devices
> -        mponly = 'devices{ filter = [ "a|/dev/mapper/mpath.*|", "r|.*|" ] }'
> +        # only operate on mp devices or encrypted volumes
> +        mponly = 'devices{ filter = [ "a|%s|", "a|%s|", "r|.*|" ] }' % (
> +            '/dev/mapper/mpath.*', '/dev/mapper/dm_crypt-.*')

In theory we should port this over to call _generate_multipath_filter.

>  
>      for cmd in [['pvscan'], ['vgscan']]:
>          if release != 'precise' and lvmetad_running():


-- 
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/407568
Your team curtin developers is subscribed to branch curtin:master.