curtin-dev team mailing list archive

[Dan Bungert <mp+414408@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

Looks good, I just want a comment added.

Diff comments:

> diff --git a/curtin/commands/apt_config.py b/curtin/commands/apt_config.py
> index bbaf7e0..734d6e5 100644
> --- a/curtin/commands/apt_config.py
> +++ b/curtin/commands/apt_config.py
> @@ -623,9 +623,6 @@ def apply_apt_preferences(cfg, pref_fname):
>  
>      prefs = cfg.get("preferences")
>      if not prefs:
> -        if os.path.isfile(pref_fname):

I'd like a comment in the code right here so that we remember why we aren't removing the file anymore.

> -            util.del_file(pref_fname)
> -            LOG.debug("no apt preferences configured, removed %s", pref_fname)
>          return
>      prefs_as_strings = [preference_to_str(pref) for pref in prefs]
>      LOG.debug("write apt preferences info to %s.", pref_fname)


-- 
https://code.launchpad.net/~ogayot/curtin/+git/curtin/+merge/414408
Your team curtin developers is subscribed to branch curtin:master.