curtin-dev team mailing list archive

[Michael Hudson-Doyle <mp+415929@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/tests/vmtests/test_basic.py b/tests/vmtests/test_basic.py
> index 6059bd9..616d635 100644
> --- a/tests/vmtests/test_basic.py
> +++ b/tests/vmtests/test_basic.py
> @@ -41,10 +41,6 @@ class TestBasicAbs(VMBaseClass):
>          f="btrfs_uuid_diskc"
>          if command -v btrfs-debug-tree >/dev/null; then
>             btrfs-debug-tree -r $dev | awk '/^uuid/ {print $2}' | grep "-"
> -           # btrfs-debug-tree fails in centos66, use btrfs-show instead
> -           if [ "$?" != "0" ]; then

centos 6 is so EOL that I can't seem to find out which version of btrfs-tools/btrfs-proges it has. My vote is we just delete this and see if it causes problems in a subsequent vm test run

> -               btrfs-show $dev | awk '/uuid/ {print $4}'
> -           fi
>          else
>             btrfs inspect-internal dump-super $dev |
>                 awk '/^dev_item.fsid/ {print $2}'


-- 
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/415929
Your team curtin developers is requested to review the proposed merge of ~mwhudson/curtin:no-centos6 into curtin:master.