curtin-dev team mailing list archive

[Dan Bungert <mp+429603@xxxxxxxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> diff --git a/curtin/commands/block_meta.py b/curtin/commands/block_meta.py
> index d01333e..cef0e49 100644
> --- a/curtin/commands/block_meta.py
> +++ b/curtin/commands/block_meta.py
> @@ -2096,7 +2105,7 @@ def meta_custom(args):
>          with open(device_map_path, 'w') as fp:
>              json.dump(context.id_to_device, fp)
>  
> -    if args.testmode:
> +    if args.testmode and DEVS:

I assume this isn't really related to the MP, and just a robustness improvement?

>          util.subp(['losetup', '--detach'] + list(DEVS))
>  
>      if args.umount:


-- 
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/429603
Your team curtin developers is subscribed to branch curtin:master.