← Back to team overview

curtin-dev team mailing list archive

Thread
Date

Re: [Merge] ~dbungert/curtin:lp-1892494-apt-key-v2 into curtin:master

To: mp+432335@xxxxxxxxxxxxxxxxxx
From: Olivier Gayot <mp+432335@xxxxxxxxxxxxxxxxxx>
Date: Tue, 01 Nov 2022 10:43:05 -0000
In-reply-to: <166698337618.25104.5027386991866786684.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+432335@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Review: Approve

LGTM, thanks!
I'd suggest using keyname instead of filename in add_apt_key* functions) to make it clear that the paremeter is not used as is (we keep only the basename and append an extension based on the key format).
-- 
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/432335
Your team curtin developers is subscribed to branch curtin:master.

References

[Merge] ~dbungert/curtin:lp-1892494-apt-key-v2 into curtin:master
From: Dan Bungert, 2022-10-28