curtin-dev team mailing list archive

Thread
Date

Re: [Merge] ~dbungert/curtin:no-attrs into curtin:master

To: mp+436274@xxxxxxxxxxxxxxxxxx
From: Olivier Gayot <mp+436274@xxxxxxxxxxxxxxxxxx>
Date: Tue, 24 Jan 2023 19:46:09 -0000
In-reply-to: <167458483794.27475.2398998444444862702.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+436274@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

The patch seems good, but for WorkingDir, the export function still uses attr.asdict ; so we cannot completely remove attr yet.

I guess replacing attr.asdict(self) by self.__dict__ would be an option but I remember mwhudson advising against the approach.

Maybe enumerating all elements is cleaner.
-- 
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/436274
Your team curtin developers is requested to review the proposed merge of ~dbungert/curtin:no-attrs into curtin:master.

References

[Merge] ~dbungert/curtin:no-attrs into curtin:master
From: Dan Bungert, 2023-01-24