curtin-dev team mailing list archive

[Dimitri John Ledkov <mp+439880@xxxxxxxxxxxxxxxxxx>]

It would be interesting to know what workloads are being deployed and how. Can you elaborate and explain f2fs insterest here?

Curtin typically targets installing onto general purpose hardware, meaning servers and desktops and thus uses filesystems by default on reliable and expensive hard drives - most commonly NVMe these days.

Even if one is deploying onto sdcard/MMC storage it would normally be most suitable to deploy prepartitioned / preinstalled images (including when using Maas connected to embedded systems).

Adding this support like this is fine, and make it available to be used with custom Curtin or Autoinstall yaml. But without any further details, it doesn't quite make sense to expose this filesystem by default in the curated lists of suitable general filesystems in the Ubuntu Server or Desktop installers.


Diff comments:

> diff --git a/curtin/block/schemas.py b/curtin/block/schemas.py
> index 3278331..60807d9 100644
> --- a/curtin/block/schemas.py
> +++ b/curtin/block/schemas.py
> @@ -4,7 +4,7 @@ _uuid_pattern = (
>      r'[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}')
>  _path_dev = r'^/dev/[^/]+(/[^/]+)*$'
>  _path_nondev = r'(^/$|^(/[^/]+)+$)'
> -_fstypes = ['btrfs', 'ext2', 'ext3', 'ext4', 'fat', 'fat12', 'fat16', 'fat32',
> +_fstypes = ['btrfs', 'ext2', 'ext3', 'ext4', 'f2fs', 'fat', 'fat12', 'fat16', 'fat32',

Oh I wish we would use black for all of this. Or just rewrap the lines. Keeping them alphabetical is nice.

>              'iso9660', 'vfat', 'jfs', 'ntfs', 'reiserfs', 'swap', 'xfs',
>              'zfsroot']
>  _ptable_unsupported = 'unsupported'
> diff --git a/debian/control b/debian/control
> index a35cbf6..0527580 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -25,6 +25,7 @@ Priority: extra
>  Depends: bcache-tools,
>           btrfs-progs | btrfs-tools,
>           dosfstools,
> +         f2fs-tools,

Indeed this filesystem is highly specialized and not really interesting to be available by default, or offline.

>           file,
>           gdisk,
>           lvm2,


-- 
https://code.launchpad.net/~nexusprism/curtin/+git/curtin/+merge/439880
Your team curtin developers is requested to review the proposed merge of ~nexusprism/curtin:master into curtin:master.