curtin-dev team mailing list archive

[Dan Bungert <mp+439880@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/debian/control b/debian/control
> index a35cbf6..0527580 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -25,6 +25,7 @@ Priority: extra
>  Depends: bcache-tools,
>           btrfs-progs | btrfs-tools,
>           dosfstools,
> +         f2fs-tools,

So the above detect_required_packages_mapping is part of how curtin handles this scenario of a package being missing.  If you were installing offline, I would indeed expect this to fail since f2fs-tools isn't part of the on-iso pool of packages.  If you were online then something may have gone wrong, we might need to double check the detect_required_packages_mapping implementation above.  We really should ensure the detect_required_packages_mapping results in f2fs-tools being installed as needed, rather than enforcing that tools package to be installed for every curtin use case.

But there is a larger discussion we're dancing around here, on the notion of the inclusion of f2fs as one of the short-list filesystems offered by either of the Subiquity-based installers.  There is some dispute on how widely f2fs should be used as a root filesystem - I can tell from the above discussion that you feel otherwise, but some perceive this filesystem as more niche.

f2fs-tools today is in universe - by definition the repo of software that is not officially supported.  Listing it at all in the UI of the installer would mean that this package would need to be promoted to main, which means that a team at Canonical has agreed to support it and that Security has had time to review it and believes that they can provide suitable security updates.  And we are rather close to release to be doing such things - that's the sort of thing one chases down before feature freeze, which was February 23rd.

If your goal is to see this integration complete in time for Lunar I think we need to reevaluate.  If we're building capabilities for future releases then this is fine, but know that this may receive less attention as the focus is on Lunar right now.

>           file,
>           gdisk,
>           lvm2,


-- 
https://code.launchpad.net/~nexusprism/curtin/+git/curtin/+merge/439880
Your team curtin developers is subscribed to branch curtin:master.