curtin-dev team mailing list archive

Thread
Date

Re: [Merge] ~ogayot/curtin:sfdisk-accept-utf8 into curtin:master

To: mp+442225@xxxxxxxxxxxxxxxxxx
From: Olivier Gayot <mp+442225@xxxxxxxxxxxxxxxxxx>
Date: Thu, 11 May 2023 12:01:37 -0000
In-reply-to: <168304579527.19067.1509516262336653792.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+442225@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

> Thanks, this all looks reasonable.
An integration test would be nice - I think it should play out similar to test_gpt_uuid_persistent. WDYT?

Thanks! There was test_gpt_name_persistent that existed already. But since you asked, I've added a new test that covers more use-cases (accents + other unicode characters). Hope that's better.

> Off that was a bit of a brain-o on my part. As Dan says, an integration test would be nice.

Done!

NOTE: I'm reluctant to let the CI squash the 3 commits together. If you don't mind, let's merge using the merge guidelines rather than leaving that up to the CI. Thanks!
-- 
https://code.launchpad.net/~ogayot/curtin/+git/curtin/+merge/442225
Your team curtin developers is requested to review the proposed merge of ~ogayot/curtin:sfdisk-accept-utf8 into curtin:master.

References

[Merge] ~ogayot/curtin:sfdisk-accept-utf8 into curtin:master
From: Olivier Gayot, 2023-05-02