curtin-dev team mailing list archive

Thread
Date

Re: [Merge] curtin:integration-memory-error into curtin:master

To: mp+442650@xxxxxxxxxxxxxxxxxx
From: Olivier Gayot <mp+442650@xxxxxxxxxxxxxxxxxx>
Date: Thu, 11 May 2023 20:50:11 -0000
In-reply-to: <168380785197.28859.11046281906228035820.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+442650@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

> Do any of the tests care about if the file is sparse or not? I suspect they do not.

I initially made it a sparse file using "dd ... count=0 seek={size}" which was equivalent although your truncate command is more readable.

I don't think any of the test cares if a file is sparse. However, I was worried that tests might not be happy if they start with existing data from an earlier test.
If there are no calls to add_image(..., create=True) with an existing path, I guess we can go for the sparse file.
-- 
https://code.launchpad.net/~curtin-dev/curtin/+git/curtin/+merge/442650
Your team curtin developers is subscribed to branch curtin:master.