curtin-dev team mailing list archive

[Michael Hudson-Doyle <mp+443376@xxxxxxxxxxxxxxxxxx>]

Review: Approve

All this looks fine. Are you going to merge manually?

Diff comments:

> diff --git a/test-requirements.txt b/test-requirements.txt
> index 1970d03..0d93c02 100644
> --- a/test-requirements.txt
> +++ b/test-requirements.txt
> @@ -1,3 +1,6 @@
> +pip
> +wheel
> +virtualenv

Do you really need to add things to both requirements.txt and test-requirements.txt?

>  jsonschema
>  mock
>  nose


-- 
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/443376
Your team curtin developers is subscribed to branch curtin:master.