← Back to team overview

curtin-dev team mailing list archive

Re: [Merge] ~dbungert/curtin:integration-old-sfdisk into curtin:master

 


Diff comments:

> diff --git a/tests/integration/test_block_meta.py b/tests/integration/test_block_meta.py
> index d14a3f8..a666bcc 100644
> --- a/tests/integration/test_block_meta.py
> +++ b/tests/integration/test_block_meta.py
> @@ -1195,10 +1198,11 @@ class TestBlockMeta(IntegrationTestCase):
>                           preserve=True)
>          script = '''\
>  label: gpt
> -first-lba: 34'''.encode()
> +first-lba: 34
> +1MiB 1MiB L'''.encode()

Oh I found the commit message now. A comment might be useful here!

>          with loop_dev(self.img) as dev:
>              cmd = ['sfdisk', dev]
> -            util.subp(cmd, data=script)
> +            util.subp(cmd, data=script, capture=True)
>  
>          config.add_part(number=1, offset=1 << 20, size=1 << 20)
>          self.run_bm(config.render())


-- 
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/443379
Your team curtin developers is subscribed to branch curtin:master.



References