curtin-dev team mailing list archive

[Michael Hudson-Doyle <mp+444316@xxxxxxxxxxxxxxxxxx>]

Michael Hudson-Doyle has proposed merging ~mwhudson/curtin:optional-sources into curtin:master.

Commit message:
curtin.commands.install: allow invocation without sources

Now that you can invoke the install subcommand more than once, sources
are only required for the "extract" step and the extract subcommand
produces a semi reasonable message if no sources are provided.



Requested reviews:
  curtin developers (curtin-dev)

For more details, see:
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/444316
-- 
Your team curtin developers is requested to review the proposed merge of ~mwhudson/curtin:optional-sources into curtin:master.

diff --git a/curtin/commands/install.py b/curtin/commands/install.py
index 7ccad87..3309c63 100644
--- a/curtin/commands/install.py
+++ b/curtin/commands/install.py
@@ -454,8 +454,6 @@ def cmd_install(args):
     LOG.info(INSTALL_START_MSG)
     LOG.debug('LANG=%s', os.environ.get('LANG'))
     LOG.debug("merged config: %s" % cfg)
-    if not len(cfg.get('sources', [])):
-        raise util.BadUsage("no sources provided to install")
 
     migrate_proxy_settings(cfg)
     for k in ('http_proxy', 'https_proxy', 'no_proxy'):