curtin-dev team mailing list archive

[Dan Bungert <mp+460552@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing



Diff comments:

> diff --git a/curtin/commands/in_target.py b/curtin/commands/in_target.py
> index c6f7abd..5c2daf0 100644
> --- a/curtin/commands/in_target.py
> +++ b/curtin/commands/in_target.py
> @@ -46,6 +46,9 @@ def in_target_main(args):
>          daemons = True
>      cmd = args.command_args
>      with util.ChrootableTarget(target, allow_daemons=daemons) as chroot:
> +        # Symlink true to ischroot since we may be in separate PID
> +        # namespace, which can throw off ischroot
> +        chroot.subp(['ln', '-sf', '/usr/bin/true', '/usr/bin/ischroot'])

While the target is a chroot at the time it is running, it is also the future installed system.  This would harm the target system, removing the ischroot binary but not replacing it later. This symlink would remain in the installed system and report as chroot for systems that aren't.

>          exit = 0
>          if not args.interactive:
>              try:


-- 
https://code.launchpad.net/~mitchellaugustin/curtin/+git/curtin/+merge/460552
Your team curtin developers is subscribed to branch curtin:master.