← Back to team overview

curtin-dev team mailing list archive

Re: [Merge] ~jw-raven/curtin:preserve-luks into curtin:master

 

Thanks for the proposal Josef!

If you haven't yet, I need you to sign the CLA. https://ubuntu.com/legal/contributors and if you have, please clarify that, as you appear to not be in the group and that will need to be investigated.

This breaks an existing unit test, I appreciate if you'd invetigate.  The existing unit test may well be incorrect.  It would be appreciated as well to add a test case for this scenario.  `tox -e py3,py3-flake8` is a good shorthand for the tests that CI will run.  CI will also demand a commit message be set on the MP, so I've suggested one here based on the content (but that only matters if we squash the MP).
-- 
https://code.launchpad.net/~jw-raven/curtin/+git/curtin/+merge/460745
Your team curtin developers is requested to review the proposed merge of ~jw-raven/curtin:preserve-luks into curtin:master.



References