← Back to team overview

curtin-dev team mailing list archive

Re: [Merge] ~dbungert/curtin:fix-volume-id into curtin:master

 

> Um something is confused here. lsblk does not output PARTUUID

I think we're both confused :)
Before and after this MP, the dm_crypt code is asking blkid for some form of a UUID.  My goal here is to not have a PARTUUID be treated as if it were the UUID, as they appear to be different values.  And indeed blkid can output a PARTUUID.

> I'm also not sure when PTUUID would be a useful thing to include

This is a general function, I have no use case for PTUUID, but blkid can indeed output that if you point it at a disk.  So yes, I have no plan for pointing cryptsetup at it, but I was wondering if another use case would emerge for the function.  So I could drop that part of the code or I could internalize this logic to dm_crypt a bit.  Thoughts?
-- 
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/460876
Your team curtin developers is requested to review the proposed merge of ~dbungert/curtin:fix-volume-id into curtin:master.



References