curtin-dev team mailing list archive

Thread
Date

Re: [Merge] ~dbungert/curtin:py312 into curtin:master

To: mp+462809@xxxxxxxxxxxxxxxxxx
From: Dan Bungert <mp+462809@xxxxxxxxxxxxxxxxxx>
Date: Wed, 20 Mar 2024 23:46:06 -0000
In-reply-to: <171095749829.3100379.13069629190720474478.launchpad@juju-98d295-prod-launchpad-17>
Reply-to: mp+462809@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

This MP is long and likely to induce eye-glazing, so as a review suggestion consider:
* doing the two search and replaces manually against the baseline commit of the MP
* fix the 4 whitespace issues created after shortening assertEquals -> assertEqual - `tox -e py3-flake8` will be happy to point these out
* the result should match what this MP shows.
-- 
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/462809
Your team curtin developers is requested to review the proposed merge of ~dbungert/curtin:py312 into curtin:master.

References

[Merge] ~dbungert/curtin:py312 into curtin:master
From: Dan Bungert, 2024-03-20