← Back to team overview

curtin-dev team mailing list archive

[Merge] ~ogayot/curtin:flake8-consistent into curtin:master

 

Olivier Gayot has proposed merging ~ogayot/curtin:flake8-consistent into curtin:master.

Commit message:
Do not read .flake8 configuration files when running py3-flake8

flake8, when invoked, will try to source configuration from a .flake8
file in the current directory. If it does not find it, it then looks in
the parent directory and so repeatedly until it finds a configuration
file (or gives up if no config file is found).

Since we do not have a .flake8 in the repository, the behavior of `tox
-e py3-flake8` is not consistent accross different environments.

Let's use the --isolated option so that the behavior is the same when
running tox -e py3-flake8 in CI and on local machines.

Signed-off-by: Olivier Gayot <olivier.gayot@xxxxxxxxxxxxx>


Requested reviews:
  curtin developers (curtin-dev)

For more details, see:
https://code.launchpad.net/~ogayot/curtin/+git/curtin/+merge/472312
-- 
Your team curtin developers is requested to review the proposed merge of ~ogayot/curtin:flake8-consistent into curtin:master.
diff --git a/tox.ini b/tox.ini
index 228dab0..964ba77 100644
--- a/tox.ini
+++ b/tox.ini
@@ -30,7 +30,7 @@ sitepackages = true
 [testenv:py3-flake8]
 basepython = python3
 deps = {[testenv]deps}
-commands = {envpython} -m flake8 {posargs:curtin tests/}
+commands = {envpython} -m flake8 {posargs:--isolated curtin tests/}
 
 [testenv:py3-pyflakes]
 basepython = python3

Follow ups