← Back to team overview

curtin-dev team mailing list archive

Re: [Merge] ~laiderlai/curtin:oem into curtin:master

 

Hi Daniel,

Thanks for your review. The commit content is updated.

1. Sorry for my misunderstanding about the /.disk/info.
We refine it to check the content of /.disk/info.
OEM images must have PROJECT and SERIES parameters.

2. For curthooks, we make the Ubuntu-image tool to handle all customization when the image is built.
Some customization parts are similar to the curthooks, such as cloud-init.
Therefore, we expect curtin not to do any hook operations (including new hooks in the future).

But OEM may need some hooks for customers' manufacturing lines. (supposition)
Maybe some settings need to be derived from the real devices (ex. SN) ASAP. Then curtin hook is a choice.
Do you think whether better if we add the ubuntu_oem_curthooks() function with the empty content at this moment?

Tks.
-- 
https://code.launchpad.net/~laiderlai/curtin/+git/curtin/+merge/475096
Your team curtin developers is subscribed to branch curtin:master.



References