curtin-dev team mailing list archive

[Sebastien Bacher <mp+478991@xxxxxxxxxxxxxxxxxx>]

Sebastien Bacher has proposed merging ~seb128/curtin:error-string-syntax into curtin:master.

Requested reviews:
  curtin developers (curtin-dev)

For more details, see:
https://code.launchpad.net/~seb128/curtin/+git/curtin/+merge/478991

I noticed the error while triaging https://bugs.launchpad.net/subiquity/+bug/2093119 where the error in the log is

('%s: not an existing file or block device', '/dev/pve/data')
-- 
Your team curtin developers is requested to review the proposed merge of ~seb128/curtin:error-string-syntax into curtin:master.

diff --git a/curtin/block/__init__.py b/curtin/block/__init__.py
index 0de202a..f0445ae 100644
--- a/curtin/block/__init__.py
+++ b/curtin/block/__init__.py
@@ -1244,7 +1244,7 @@ def quick_zero(path, partitions=True, exclusive=True):
     offsets = [0, -zero_size]
     is_block = is_block_device(path)
     if not (is_block or os.path.isfile(path)):
-        raise ValueError("%s: not an existing file or block device", path)
+        raise ValueError("%s: not an existing file or block device" % path)
 
     pt_names = []
     if partitions and is_block: