curtin-dev team mailing list archive

[Olivier Gayot <mp+481078@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~ogayot/curtin:raid+ptable into curtin:master has been updated.

Description changed to:

On a partitioned RAID device that already includes an ESP, using Subiquity's use-gap results in the creation of another ESP ; instead of reusing the existing one:

2025-02-12 10:50:01,502 DEBUG subiquity.server.controllers.filesystem:1380 GuidedChoiceV2(target=GuidedStorageTargetUseGap(disk_id='raid-md126', gap=Gap(offset=14013169664, size=958997200896, ...))
2025-02-12 10:50:01,502 DEBUG subiquity.models.filesystem:2345 adding fat32 to Partition(device=raid-md126, size=1127219200, wipe='superblock', flag='boot', number=3, grub_device=True, offset=14013169664, id='partition-0')
2025-02-12 10:50:01,503 DEBUG subiquity.models.filesystem:2345 adding ext4 to Partition(device=raid-md126, size=957869981696, wipe='superblock', number=4, grub_device=None, offset=15140388864, id='partition-1')

This is because curtin does not include the ptable value in the resulting storage config.

Also, having no value for the ptable means subiquity uses the default type (i.e., GPT) when creating a new partition. This would not have worked very well if the original ptable was MSDOS.

After applying the patch, using use-gap results in the following:

2025-02-12 10:21:00,644 DEBUG subiquity.server.controllers.filesystem:1380 GuidedChoiceV2(target=GuidedStorageTargetUseGap(disk_id='raid-md126', gap=Gap(offset=14013169664, size=958997200896, ...)
2025-02-12 10:21:00,644 DEBUG subiquity.models.filesystem:2345 adding ext4 to Partition(device=raid-md126, size=958997200896, wipe='superblock', number=3, grub_device=None, offset=14013169664, id='partition-0')


For more details, see:
https://code.launchpad.net/~ogayot/curtin/+git/curtin/+merge/481078
-- 
Your team curtin developers is requested to review the proposed merge of ~ogayot/curtin:raid+ptable into curtin:master.