curtin-dev team mailing list archive

[Chris Peterson <mp+481186@xxxxxxxxxxxxxxxxxx>]

This does seem cleaner! One small comment.

Diff comments:

> diff --git a/curtin/storage_config.py b/curtin/storage_config.py
> index 8646a2e..e00b380 100644
> --- a/curtin/storage_config.py
> +++ b/curtin/storage_config.py
> @@ -845,8 +845,8 @@ class BlockdevParser(ProbertParser):
>                          part = {
>                              'start': attrs['start'],
>                              'size': attrs['size'],
> -                            'visible-in-ptable': False,
>                          }
> +                        ptable = None

>  if we notice that the partition is not actually associated with the partition table.. [we set the ptable to None] so that we don't try to retrieve properties from the
ptable later.

Does it make sense to add a comment in the code to this effect too, or is this obvious? On read through it helps me, but I'm far less familiar with the code here.

>                      else:
>                          raise RuntimeError(
>                              "Couldn't find partition entry in table")


-- 
https://code.launchpad.net/~ogayot/curtin/+git/curtin/+merge/481186
Your team curtin developers is requested to review the proposed merge of ~ogayot/curtin:dyndisk-ptable=none into curtin:master.