curtin-dev team mailing list archive

[Chris Peterson <mp+482849@xxxxxxxxxxxxxxxxxx>]

Review: Approve

LGTM. One non-blocking comment. Thanks!

Diff comments:

> diff --git a/curtin/commands/curthooks.py b/curtin/commands/curthooks.py
> index 381d59e..efd4d93 100644
> --- a/curtin/commands/curthooks.py
> +++ b/curtin/commands/curthooks.py
> @@ -2102,6 +2112,13 @@ def builtin_curthooks(cfg, target, state):
>              redhat_update_initramfs(target, cfg)
>  
>      with events.ReportEventStack(
> +            name=stack_prefix + '/kernel-postinstall',
> +            reporting_enabled=True, level="INFO",
> +            description=""):

suggestion(non-blocking): we could probably fill the description with something along the lines of the comment in reconfigure_kernel() -> "re-running kernel postinstall hooks"

> +        if osfamily == DISTROS.debian:
> +            reconfigure_kernel(target)
> +
> +    with events.ReportEventStack(
>              name=stack_prefix + '/configuring-bootloader',
>              reporting_enabled=True, level="INFO",
>              description="configuring target system bootloader"):


-- 
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/482849
Your team curtin developers is subscribed to branch curtin:master.