← Back to team overview

curtin-dev team mailing list archive

Re: [Merge] ~r00ta/curtin:maas-debian-cloudconfig into curtin:master

 


Diff comments:

> diff --git a/curtin/commands/curthooks.py b/curtin/commands/curthooks.py
> index b54e3c9..c334c94 100644
> --- a/curtin/commands/curthooks.py
> +++ b/curtin/commands/curthooks.py
> @@ -1689,7 +1689,9 @@ def handle_cloudconfig(cfg, base_dir=None):
>      #   generate a path based on item key
>      #   if path is already in the item, LOG warning, and use generated path
>      for cfgname, cfgvalue in cfg.items():
> -        cfgpath = "50-cloudconfig-%s.cfg" % cfgname
> +        # cloud-init on debian-like distros includes a config '90_dpkg'.
> +        # To ensure our config is applied afterward, we use a prefix > 90.
> +        cfgpath = "95-cloudconfig-%s.cfg" % cfgname

You mean https://github.com/canonical/cloud-init/blob/0eb476f6360fb6326efb3e0882338cb420007f69/debian/cloud-init-base.config#L64 
> old_dpkg_cfg is very old file that is no longer read by cloud-init.

? 

This is not what I've observed, that 90_dpkg file is still used by cloud init and using a prefix < 90 is not working (in noble, at least). We need somebody from cloud-init to clarify this aspect.

>          if 'path' in cfgvalue:
>              LOG.warning("cloudconfig ignoring 'path' key in config")
>          cfgvalue['path'] = cfgpath


-- 
https://code.launchpad.net/~r00ta/curtin/+git/curtin/+merge/486221
Your team curtin developers is requested to review the proposed merge of ~r00ta/curtin:maas-debian-cloudconfig into curtin:master.



References