curtin-dev team mailing list archive

[Dan Bungert <mp+486221@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/curtin/commands/curthooks.py b/curtin/commands/curthooks.py
> index b54e3c9..c334c94 100644
> --- a/curtin/commands/curthooks.py
> +++ b/curtin/commands/curthooks.py
> @@ -1689,7 +1689,9 @@ def handle_cloudconfig(cfg, base_dir=None):
>      #   generate a path based on item key
>      #   if path is already in the item, LOG warning, and use generated path
>      for cfgname, cfgvalue in cfg.items():
> -        cfgpath = "50-cloudconfig-%s.cfg" % cfgname
> +        # cloud-init on debian-like distros includes a config '90_dpkg'.
> +        # To ensure our config is applied afterward, we use a prefix > 90.
> +        cfgpath = "95-cloudconfig-%s.cfg" % cfgname

OK, so 90_dpkg is mostly about the datasource_list value, which MAAS is also attempting to manage.  So I can sure understand why that value is desired to be in a file above 90.

My concern now is about breaking existing workflows.  Does MAAS have customers who have seeded files at a number > 50 and < 95, who aren't setting a datasource_list file, who would be broken by this change?

>          if 'path' in cfgvalue:
>              LOG.warning("cloudconfig ignoring 'path' key in config")
>          cfgvalue['path'] = cfgpath


-- 
https://code.launchpad.net/~r00ta/curtin/+git/curtin/+merge/486221
Your team curtin developers is requested to review the proposed merge of ~r00ta/curtin:maas-debian-cloudconfig into curtin:master.