debcrafters-packages team mailing list archive
-
debcrafters-packages team
-
Mailing list archive
-
Message #00626
[Bug 2100598] Re: [FFe]: re-enable DFLTCC on s390x
** Changed in: ubuntu-z-systems
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to gzip in Ubuntu.
https://bugs.launchpad.net/bugs/2100598
Title:
[FFe]: re-enable DFLTCC on s390x
Status in Ubuntu on IBM z Systems:
Fix Released
Status in gzip package in Ubuntu:
Fix Released
Status in gzip source package in Plucky:
Fix Released
Bug description:
DFLTCC on s390x is a feature that was disabled to address an FTBFS in
that code. This was done before feature freeze in [1].
We later found out the real fix[2] for the FTBFS, and it's in an MP attached to this bug. The diff is twofold:
- a revert of [1]
- this change:
--- a/debian/rules
+++ b/debian/rules
@@ -31,8 +31,12 @@ ifeq ($(buildarch), amd64)
DEB_CPPFLAGS_MAINT_APPEND := -DUNALIGNED_OK
endif
+# For why -Dalignas, see:
+# https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66709#10
+# and
+# LP: #2100598
ifeq (${DEB_HOST_ARCH},s390x)
-DEB_CPPFLAGS_MAINT_APPEND := -DDFLTCC -DDFLTCC_LEVEL_MASK=0x7e
+DEB_CPPFLAGS_MAINT_APPEND := -DDFLTCC -DDFLTCC_LEVEL_MASK=0x7e -Dalignas=_Alignas
endif
# Automatic dpkg-buildflags selection, backport-friendly
PPA[3] with that fix, showing an s390x and amd64 builds.
DEP8 tests will be run after the PPA publishes, but they are rather trivial.
This feature was disabled by mistake, one could say, and is now being
re-enabled. Still, it's a change in behavior post FF, for just s390x,
and warrants an FFe request.
1. https://launchpad.net/ubuntu/+source/gzip/1.13-1ubuntu2
2. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66709#10
3. https://launchpad.net/~ahasenack/+archive/ubuntu/gzip-sigill/
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/2100598/+subscriptions