debcrafters-packages team mailing list archive

[Jeremy Bícha <2109853@xxxxxxxxxxxxxxxxxx>]

>From Ubuntu Desktop 25.04, I did:

sudo adduser --allow-all-users test@xxxxxxxxxxxxx

I then used the Settings app (gnome-control-center) to make this new
user an Administrator.

sudo apt install ubuntu-dev-tools sbuild
sudo groupmod -a -U test@xxxxxxxxxxxxx sbuild # This step might not be needed?

I then had to restart Ubuntu 25.04 for the change to add the user to the
sbuild group to take full effect. This is surprising since I would have
expected a simple log out and log back in to have been enough.

Then I did steps 2-4 from the Test Plan and verified the failure.
Then I installed sbuild 0.88.3ubuntu2.1 and verified that step 4 now completes successfully.

I did need to make one change. My default, sbuild created a ~/.sbuildrc with this line:
$log_dir="/home/test@xxxxxxxxxxxxx/ubuntu/logs";

I had to change from a double quote to a single quote:
$log_dir='/home/test@xxxxxxxxxxxxx/ubuntu/logs';

This is a separate bug from the original bug which prevented being able
to use sbuild at all so I am marking this verification done.

** Tags removed: verification-needed verification-needed-plucky
** Tags added: verification-done verification-done-plucky

-- 
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to sbuild in Ubuntu.
https://bugs.launchpad.net/bugs/2109853

Title:
  [SRU] Make sbuild usable for 'user@xxxxxxx' users

Status in sbuild package in Ubuntu:
  Fix Released
Status in sbuild source package in Noble:
  Fix Committed
Status in sbuild source package in Oracular:
  In Progress
Status in sbuild source package in Plucky:
  Fix Committed

Bug description:
  [Impact]

  With the increasing adoption of tools like authd, it's very likely
  that Linux desktop users in corporate environments end up with their
  usernames like 'user@xxxxxxx', what doesn't play nice with
  sbuild/schroot. Without properly escaping the username, the '@'
  character ends up being interpreted as a string interpolation what
  breaks the lock_chroot() subroutine.

  Fore more information about the issue, please check the upstream bug:
  https://salsa.debian.org/debian/sbuild/-/issues/4

  
  [ Test plan ]

  1. Make sure to have a user account containing the '@' character in its name, such as 'user@xxxxxxx'.
  2. Make sure to have a schroot environment ready. `mk-sbuild oracular` for example to create one for oracular. Note: the mk-sbuild command is provided by the ubuntu-dev-tools package, so make sure to have it installed.
  3. Retrieve the sources of a simple package: `pull-lp-source hello noble`
  4. Build the binary package with sbuild: `cd hello-2.10/ && sbuild -d noble-amd64` (adjust the schroot environment name according to your computer's architecture)

  Expected results without the patches herein proposed is a failure
  like:

  ```
  I: NOTICE: Log filtering will replace 'var/run/schroot/mount/plucky-amd64-c9a17ed0-5932-4df1-ad6e-d4df512a37b0' with '<<CHROOT>>'
  Possible unintended interpolation of @org in string at -e line 50.
  Global symbol "@org" requires explicit package name (did you forget to declare "my @org"?) at -e line 50.
  Execution of -e aborted due to compilation errors.
  E: Error locking chroot session: skipping livecd-rootfs
  ```

  Building the package should proceed normally with the patches applied.


  [ Where problems could occur ]

  The scope of the changes herein proposed is so small and self-contained that I 
  don't expect any issues arising from it under any circumstances.

  
  [ Other Info ]

  I'm skipping 'Questing', as I expect it to receive the fix via debian merges,
  sbuild version 0.89.2 (just accepted into Debian unstable) contains this patch (alongside other stuff).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/sbuild/+bug/2109853/+subscriptions