debcrafters-packages team mailing list archive
-
debcrafters-packages team
-
Mailing list archive
-
Message #02147
[Bug 2111952] Re: Remmina prompts for RDP credentials even when they are saved
Thanks for your input Andreas and Nikolay.
Updates:
* Added suggested tests to the test plan.
* Confirmed updated test plan passes on noble with patched remmina.
* Added Oracular as additional target series to the bug.
* Put up MP for oracular: https://code.launchpad.net/~ankushpathak/ubuntu/+source/remmina/+git/remmina/+merge/487085
* Updated test plan passes on oracular with patched remmina.
** Description changed:
[ Impact ]
Remmina 1.4.35 prompts for RDP credentials even they are saved. It shows the credentials dialog prefilled with the username and password.
The expected behavior for Remmina is to proceed with the connection without prompting user for their credentials.
Users generally use connection profiles with saved credentials to make the tool more convenient to use.
However, this bug requires a redundant click before establishing connection.
The additional prompt with filled credentials may also confuse users that the connection failed due to incorrect credentials resulting in a prompt for updated credentials.
Upstream issue: https://gitlab.com/Remmina/Remmina/-/issues/3111
Merge request: https://gitlab.com/Remmina/Remmina/-/merge_requests/2592/diffs
The patch short-circuits the part of the authentication flow where the
credentials are requested from the user, if they are already available.
The patch is simple and small in size. Overall, seems like a safe change
to SRU.
[ Test Plan ]
* Setup a new connection profile by clicking on the "+" on the top left corner after starting Remmina.
* Fill server address, username and password. Make sure protocol selected is RDP.
* Save the profile.
* Attempt connection by double clicking on the saved profile or clicking connect from the right-click context menu on the profile.
* Remmina should not produce a prompt with filled Username and Password fields, and instead should directly establish an RDP session with the server.
+ Test with empty credentials
+ * Edit the connection profile setup for the previous test.
+ * Empty the username field. Keep password field filled. Save the profile.
+ * Attempt the connection, Remmina should prompt for credentials with the username field empty and password field pre-filled. Upon providing the correct username connection should succeed.
+ * Repeat the test for following combinations:
+ - Username field filled and password field empty in the saved profile.
+ - Both username and password field empty in the saved profile.
+
+ Test with incorrect credentials
+ * Edit the connection profile setup for the previous test.
+ * Set the password and username field to incorrect values such that authentication to the server will fail. Save the profile.
+ * Attempt the connection, Remmina should produce a dialog with a connection log ending with "login failed for user...".
+ * After clicking "Ok", there should be a prompt asking for credentials. Connection should succeed after entering correct credentials at this prompt.
+
[ Where problems could occur ]
* Remmina may fail to authenticate RDP sessions using saved profiles with correct credentials due to an unexpected regression from the patch. The test plan will catch this regression.
* Another unlikely regression is that other config values in the profile are not correctly propagated when establishing an RDP session. A fuzzy test around setting some config values when creating the profile and ensuring an RDP session using that profile behaves as expected should cover this.
[Original Report]
Remmina 1.4.35 prompts for RDP credentials even when they are saved. It
shows the credentials dialog prefilled with the username and password.
This behavior is observed only when using RDP or TLS security protocol
negotiation. NLA is not affected.
The expected behavior for Remmina is to proceed with the connection
without prompting user for their credentials.
This issue was fixed upstream in version 1.4.36
Patch for this fix is attached.
Upstream issue: https://gitlab.com/Remmina/Remmina/-/issues/3111
Merge request: https://gitlab.com/Remmina/Remmina/-/merge_requests/2592/diffs
** Also affects: remmina (Ubuntu Oracular)
Importance: Undecided
Status: New
** Changed in: remmina (Ubuntu Oracular)
Status: New => In Progress
** Changed in: remmina (Ubuntu Oracular)
Assignee: (unassigned) => Ankush Pathak (ankushpathak)
--
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to remmina in Ubuntu.
https://bugs.launchpad.net/bugs/2111952
Title:
Remmina prompts for RDP credentials even when they are saved
Status in remmina package in Ubuntu:
Fix Released
Status in remmina source package in Jammy:
Invalid
Status in remmina source package in Noble:
Incomplete
Status in remmina source package in Oracular:
In Progress
Bug description:
[ Impact ]
Remmina 1.4.35 prompts for RDP credentials even they are saved. It shows the credentials dialog prefilled with the username and password.
The expected behavior for Remmina is to proceed with the connection without prompting user for their credentials.
Users generally use connection profiles with saved credentials to make the tool more convenient to use.
However, this bug requires a redundant click before establishing connection.
The additional prompt with filled credentials may also confuse users that the connection failed due to incorrect credentials resulting in a prompt for updated credentials.
Upstream issue: https://gitlab.com/Remmina/Remmina/-/issues/3111
Merge request: https://gitlab.com/Remmina/Remmina/-/merge_requests/2592/diffs
The patch short-circuits the part of the authentication flow where the
credentials are requested from the user, if they are already
available. The patch is simple and small in size. Overall, seems like
a safe change to SRU.
[ Test Plan ]
* Setup a new connection profile by clicking on the "+" on the top left corner after starting Remmina.
* Fill server address, username and password. Make sure protocol selected is RDP.
* Save the profile.
* Attempt connection by double clicking on the saved profile or clicking connect from the right-click context menu on the profile.
* Remmina should not produce a prompt with filled Username and Password fields, and instead should directly establish an RDP session with the server.
Test with empty credentials
* Edit the connection profile setup for the previous test.
* Empty the username field. Keep password field filled. Save the profile.
* Attempt the connection, Remmina should prompt for credentials with the username field empty and password field pre-filled. Upon providing the correct username connection should succeed.
* Repeat the test for following combinations:
- Username field filled and password field empty in the saved profile.
- Both username and password field empty in the saved profile.
Test with incorrect credentials
* Edit the connection profile setup for the previous test.
* Set the password and username field to incorrect values such that authentication to the server will fail. Save the profile.
* Attempt the connection, Remmina should produce a dialog with a connection log ending with "login failed for user...".
* After clicking "Ok", there should be a prompt asking for credentials. Connection should succeed after entering correct credentials at this prompt.
[ Where problems could occur ]
* Remmina may fail to authenticate RDP sessions using saved profiles with correct credentials due to an unexpected regression from the patch. The test plan will catch this regression.
* Another unlikely regression is that other config values in the profile are not correctly propagated when establishing an RDP session. A fuzzy test around setting some config values when creating the profile and ensuring an RDP session using that profile behaves as expected should cover this.
[Original Report]
Remmina 1.4.35 prompts for RDP credentials even when they are saved.
It shows the credentials dialog prefilled with the username and
password.
This behavior is observed only when using RDP or TLS security protocol
negotiation. NLA is not affected.
The expected behavior for Remmina is to proceed with the connection
without prompting user for their credentials.
This issue was fixed upstream in version 1.4.36
Patch for this fix is attached.
Upstream issue: https://gitlab.com/Remmina/Remmina/-/issues/3111
Merge request: https://gitlab.com/Remmina/Remmina/-/merge_requests/2592/diffs
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/remmina/+bug/2111952/+subscriptions
References