← Back to team overview

debcrafters-packages team mailing list archive

[Bug 2095129] Re: Nautilus crashes when update_file_info_full is running and the folder is being left

 

Hello Philipp, or anyone else affected,

Accepted nautilus into noble-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/nautilus/1:46.4-0ubuntu0.1 in a few
hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
noble to verification-done-noble. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-noble. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: nautilus (Ubuntu Noble)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-noble

-- 
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/2095129

Title:
  Nautilus crashes when update_file_info_full is running and the folder
  is being left

Status in nautilus package in Ubuntu:
  Fix Released
Status in nautilus source package in Noble:
  Fix Committed

Bug description:
  [ Impact ]

  Nautilus crashes if nautilus-python is installed and
  update_file_info_full is running and the folder is being left. This
  happens because of a NULL deref.

  My patch checks for NULL and returns to avoid the NULL deref.

  [ Test Plan ]

  1. Install python3-nautilus
  2. Copy test.py to ~/.local/share/nautilus-python/extensions/ (https://gitlab.gnome.org/-/project/1/uploads/4becd588cc4db8294e9154813e814224/test.py)
  3. create an empty folder and open a terminal and run mkdir test_{1..500} to create a lot of empty folders in your new directory
  4. kill nautilus with nautilus -q
  5. restart nautilus with nautilus --no-desktop
  6. navigate to your folder
  7. immediately go back to the parent folder, i.e. press alt+arrow-key-up
  8. repeat folder navigation multiple times

  Nautilus should not crash.

  [ Where problems could occur ]

  Since the extension functions return now prematurely, some of the code
  paths are no longer being executed, i.e. a g_object_unref or
  finish_info_provider. This might lead to a memory leak or undefined
  extension behavior.

  Instead of crashing nautilus will output an error message.

  This fix is being included in the 46.4 SRU: bug 2108849

  [ Other Info ]

  Upstream MR: https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/1662
  Upstream issue: https://gitlab.gnome.org/GNOME/nautilus/-/issues/3505

  Since nautilus-python is not preinstalled and an extension which calls
  the async method is required, this crash and this patch does not
  affect a Ubuntu standard installation and therefore most of the Ubuntu
  users.

  Nonetheless I think this crash especially affects developers who use
  Ubuntu and a tool like turtle
  (https://gitlab.gnome.org/philippun1/turtle), which uses the nautilus
  python extension to calculate git status emblems.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/2095129/+subscriptions