debcrafters-packages team mailing list archive

[Andreas Hasenack <2111952@xxxxxxxxxxxxxxxxxx>]

Hello Nikolay, or anyone else affected,

Accepted remmina into oracular-proposed. The package will build now and
be available at
https://launchpad.net/ubuntu/+source/remmina/1.4.35+dfsg-2ubuntu0.1 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
oracular to verification-done-oracular. If it does not fix the bug for
you, please add a comment stating that, and change the tag to
verification-failed-oracular. In either case, without details of your
testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: remmina (Ubuntu Oracular)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-oracular

** Changed in: remmina (Ubuntu Noble)
       Status: In Progress => Fix Committed

** Tags added: verification-needed-noble

-- 
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to remmina in Ubuntu.
https://bugs.launchpad.net/bugs/2111952

Title:
  Remmina prompts for RDP credentials even when they are saved

Status in remmina package in Ubuntu:
  Fix Released
Status in remmina source package in Jammy:
  Invalid
Status in remmina source package in Noble:
  Fix Committed
Status in remmina source package in Oracular:
  Fix Committed

Bug description:
  [ Impact ]

  Remmina 1.4.35 prompts for RDP credentials even they are saved. It shows the credentials dialog prefilled with the username and password.
  The expected behavior for Remmina is to proceed with the connection without prompting user for their credentials.
  Users generally use connection profiles with saved credentials to make the tool more convenient to use.
  However, this bug requires a redundant click before establishing connection.
  The additional prompt with filled credentials may also confuse users that the connection failed due to incorrect credentials resulting in a prompt for updated credentials.

  Upstream issue: https://gitlab.com/Remmina/Remmina/-/issues/3111
  Merge request: https://gitlab.com/Remmina/Remmina/-/merge_requests/2592/diffs

  The patch short-circuits the part of the authentication flow where the
  credentials are requested from the user, if they are already
  available. The patch is simple and small in size. Overall, seems like
  a safe change to SRU.

  [ Test Plan ]

  * Setup a new connection profile by clicking on the "+" on the top left corner after starting Remmina.
  * Fill server address, username and password. Make sure protocol selected is RDP.
  * Save the profile.
  * Attempt connection by double clicking on the saved profile or clicking connect from the right-click context menu on the profile.
  * Remmina should not produce a prompt with filled Username and Password fields, and instead should directly establish an RDP session with the server.

  Test with empty credentials
  * Edit the connection profile setup for the previous test.
  * Empty the username field. Keep password field filled. Save the profile.
  * Attempt the connection, Remmina should prompt for credentials with the username field empty and password field pre-filled. Upon providing the correct username connection should succeed.
  * Repeat the test for following combinations: 
    - Username field filled and password field empty in the saved profile.
    - Both username and password field empty in the saved profile.

  Test with incorrect credentials
  * Edit the connection profile setup for the previous test.
  * Set the password and username field to incorrect values such that authentication to the server will fail. Save the profile.
  * Attempt the connection, Remmina should produce a dialog with a connection log ending with "login failed for user...".
  * After clicking "Ok", there should be a prompt asking for credentials. Connection should succeed after entering correct credentials at this prompt.

  [ Where problems could occur ]

  * Remmina may fail to authenticate RDP sessions using saved profiles with correct credentials due to an unexpected regression from the patch. The test plan will catch this regression.
  * Another unlikely regression is that other config values in the profile are not correctly propagated when establishing an RDP session. A fuzzy test around setting some config values when creating the profile and ensuring an RDP session using that profile behaves as expected should cover this.

  [Original Report]

  Remmina 1.4.35 prompts for RDP credentials even when they are saved.
  It shows the credentials dialog prefilled with the username and
  password.

  This behavior is observed only when using RDP or TLS security protocol
  negotiation. NLA is not affected.

  The expected behavior for Remmina is to proceed with the connection
  without prompting user for their credentials.

  This issue was fixed upstream in version 1.4.36

  Patch for this fix is attached.

  Upstream issue: https://gitlab.com/Remmina/Remmina/-/issues/3111
  Merge request: https://gitlab.com/Remmina/Remmina/-/merge_requests/2592/diffs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/remmina/+bug/2111952/+subscriptions