debcrafters-packages team mailing list archive

["E. Choroba" <2116253@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

When running gitk in a git working copy directory, it starts, but
instead of displaying the history, it shows the following error:

 Error executing git log: wrong # args:
  sholuld be
 "safe_open_command_redirect cmd redir"

I was able to fix it (after copying it from /usr/bin to ~/bin):

--- /usr/bin/gitk	2025-07-03 19:57:43.000000000 +0200
+++ /home/choroba/bin/gitk	2025-07-09 11:42:20.565361414 +0200
@@ -497,8 +497,7 @@
     }
 
     if {[catch {
-        set fd [safe_open_command_redirect [concat git log --no-color -z --pretty=raw $show_notes \
-                        --parents --boundary $args "--" $files]]
+        set fd [safe_open_command [concat git log --no-color -z --pretty=raw $show_notes --parents --boundary $args "--" $files]]
     } err]} {
         error_popup "[mc "Error executing git log:"] $err"
         return 0
@@ -645,7 +644,7 @@
         set args $vorigargs($view)
     }
     if {[catch {
-        set fd [safe_open_command_redirect [concat git log --no-color -z --pretty=raw $show_notes \
+        set fd [safe_open_command [concat git log --no-color -z --pretty=raw $show_notes \
                         --parents --boundary $args "--" $vfilelimit($view)]]
     } err]} {
         error_popup "[mc "Error executing git log:"] $err"

** Affects: git (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to git in Ubuntu.
https://bugs.launchpad.net/bugs/2116253

Title:
  gitk displays an error instead of git history

Status in git package in Ubuntu:
  New

Bug description:
  When running gitk in a git working copy directory, it starts, but
  instead of displaying the history, it shows the following error:

   Error executing git log: wrong # args:
    sholuld be
   "safe_open_command_redirect cmd redir"

  I was able to fix it (after copying it from /usr/bin to ~/bin):

  --- /usr/bin/gitk	2025-07-03 19:57:43.000000000 +0200
  +++ /home/choroba/bin/gitk	2025-07-09 11:42:20.565361414 +0200
  @@ -497,8 +497,7 @@
       }
   
       if {[catch {
  -        set fd [safe_open_command_redirect [concat git log --no-color -z --pretty=raw $show_notes \
  -                        --parents --boundary $args "--" $files]]
  +        set fd [safe_open_command [concat git log --no-color -z --pretty=raw $show_notes --parents --boundary $args "--" $files]]
       } err]} {
           error_popup "[mc "Error executing git log:"] $err"
           return 0
  @@ -645,7 +644,7 @@
           set args $vorigargs($view)
       }
       if {[catch {
  -        set fd [safe_open_command_redirect [concat git log --no-color -z --pretty=raw $show_notes \
  +        set fd [safe_open_command [concat git log --no-color -z --pretty=raw $show_notes \
                           --parents --boundary $args "--" $vfilelimit($view)]]
       } err]} {
           error_popup "[mc "Error executing git log:"] $err"

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/git/+bug/2116253/+subscriptions