debcrafters-packages team mailing list archive

Thread
Date
[Bug 2119658] Re: rsync upstream-tests fail without reported error

To: debcrafters-packages@xxxxxxxxxxxxxxxxxxx
From: Nick Rosbrook <2119658@xxxxxxxxxxxxxxxxxx>
Date: Wed, 06 Aug 2025 15:31:50 -0000
Reply-to: Bug 2119658 <2119658@xxxxxxxxxxxxxxxxxx>
Sender: noreply@xxxxxxxxxxxxx
Uploaded a fix and forwarded to debian via
https://salsa.debian.org/debian/rsync/-/merge_requests/28.

** Changed in: rsync (Ubuntu)
       Status: Triaged => Fix Committed

-- 
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to rsync in Ubuntu.
https://bugs.launchpad.net/bugs/2119658

Title:
  rsync upstream-tests fail without reported error

Status in rsync package in Ubuntu:
  Fix Committed

Bug description:
  Currently seen against openssh, but I have confirmed locally that this
  fails without -proposed. The log[1] shows:

  588s gawk -f ./daemon-parm.awk ./daemon-parm.txt
  588s gawk -f ./mkproto.awk ./*.c ./lib/compat.c daemon-parm.h
  588s gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c tls.c -o tls.o
  588s gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c syscall.c -o syscall.o
  588s gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c util2.c -o util2.o
  588s gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c t_stub.c -o t_stub.o
  588s gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c lib/compat.c -o lib/compat.o
  589s gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c lib/snprintf.c -o lib/snprintf.o
  589s gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c lib/permstring.c -o lib/permstring.o
  589s gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c lib/sysxattrs.c -o lib/sysxattrs.o
  589s gcc -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -Wl,-z,relro -Wl,-z,now -o tls tls.o syscall.o util2.o t_stub.o lib/compat.o lib/snprintf.o lib/permstring.o lib/sysxattrs.o  -lattr -lacl -lpopt -llz4 -lzstd -lxxhash -lcrypto -lz 
  589s gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c getgroups.c -o getgroups.o
  589s gcc -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -Wl,-z,relro -Wl,-z,now -o getgroups getgroups.o -lattr -lacl -lpopt -llz4 -lzstd -lxxhash -lcrypto -lz 
  589s gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c getfsdev.c -o getfsdev.o
  589s gcc -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -Wl,-z,relro -Wl,-z,now -o getfsdev getfsdev.o -lattr -lacl -lpopt -llz4 -lzstd -lxxhash -lcrypto -lz 
  589s gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c trimslash.c -o trimslash.o
  590s gcc -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -Wl,-z,relro -Wl,-z,now -o trimslash trimslash.o syscall.o util2.o t_stub.o lib/compat.o lib/snprintf.o -lattr -lacl -lpopt -llz4 -lzstd -lxxhash -lcrypto -lz 
  590s gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c t_unsafe.c -o t_unsafe.o
  590s gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c util1.c -o util1.o
  590s gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c lib/wildmatch.c -o lib/wildmatch.o
  591s gcc -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -Wl,-z,relro -Wl,-z,now -o t_unsafe t_unsafe.o syscall.o util1.o util2.o t_stub.o lib/compat.o lib/snprintf.o lib/wildmatch.o -lattr -lacl -lpopt -llz4 -lzstd -lxxhash -lcrypto -lz 
  591s gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.DRSPkm/build.soY/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c wildtest.c -o wildtest.o
  591s autopkgtest [21:12:00]: test upstream-tests-as-root: -----------------------]

  There is no error reported, so the cause of the failure is mysterious.
  Looking at debian/tests/upstream-tests, there is:

  # Supress gcc warnings (autopkg treats them as failures)
  make tls getgroups getfsdev trimslash t_unsafe wildtest testrun 2>/dev/null

  ...which explains the lack of error reporting. When running locally
  without silencing stderr, we get:

  gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/tmp/autopkgtest.RX7dXo/build.VUL/src=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/tmp/autopkgtest.RX7dXo/build.VUL/src=/usr/src/rsync-3.4.1+ds1-5 -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_FORTIFY_SOURCE=3 -c wildtest.c -o wildtest.o
  wildtest.c:35:14: error: ‘bool’ cannot be defined via ‘typedef’
     35 | typedef char bool;
        |              ^~~~
  wildtest.c:35:14: note: ‘bool’ is a keyword with ‘-std=c23’ onwards
  wildtest.c:35:1: warning: useless type name in empty declaration
     35 | typedef char bool;
        | ^~~~~~~
  make: *** [Makefile:70: wildtest.o] Error 1

  So, this seems to have been caused by the new GCC 15.

  This should be fixed in rsync by removing the typedef. At the same
  time, the debian/tests/upstream-tests script should not silence
  stderr, and instead Restrictions: allow-stderr should be used to not
  treat that as a failure.


  [1] https://autopkgtest.ubuntu.com/results/autopkgtest-
  questing/questing/amd64/r/rsync/20250804_211220_79946@/log.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rsync/+bug/2119658/+subscriptions
References

[Bug 2119658] [NEW] rsync upstream-tests fail without reported error
From: Nick Rosbrook, 2025-08-06