debcrafters-packages team mailing list archive

[Ural Tunaboyu <2112619@xxxxxxxxxxxxxxxxxx>]

Verifying on noble:

1. Enabled postprocessing and set it to a non-existent path.
2. Error message popped up with title "Failed to run postprocessing", and text indicating the postprocessing script path was not valid.
3. Changed the postprocessing script path to be valid then saved again. There was no popup.
4. Verified that the stdout and stderr from the postprocessing script get printed correctly in the debug console, and errors are reflected in the returned status code of the subprocess (without resulting in a "Failed to run postprocessing" popup).
5. Changed permissions on the postprocessing script to disable its execution by the user. There was a "Failed to run postprocessing" popup with text that indicated permission was denied.

Checking against regressions:

1. Saved with postprocessing disabled. There were no issues.

** Tags removed: verification-needed-noble
** Tags added: verification-done-noble

-- 
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to simple-scan in Ubuntu.
https://bugs.launchpad.net/bugs/2112619

Title:
  simple-scan returns error when saving when using an empty post-
  processing value

Status in simple-scan package in Ubuntu:
  Fix Released
Status in simple-scan source package in Noble:
  Fix Committed
Status in simple-scan source package in Plucky:
  Fix Committed
Status in simple-scan source package in Questing:
  Fix Released

Bug description:
  [ Impact ]

   * Errors that occur while running postprocessing scripts in simple-scan will be erroneously reported as save failures instead, leading the user to believe their file has not been saved.
   * Scripts that output into stdout and stderr are supposed to have this echoed to the terminal when running with simple-scan --debug, but do not.

  [ Test Plan ]

   * Run simple-scan with `simple-scan --debug test`.
   * In the Preferences menu, enable postprocessing.
   * Set the path of the postprocessing script to a non-existent file.
   * Attempt to save a scanned file. Saving should succeed, and the postprocessing error should get a popup with the title "Failed to run postprocessing" and a description stating the actual error.
   * There should be no popup if the postprocessing succeeds.
   * Error codes in the postprocessing script itself should not result in an error popup, only if the provided script path is incorrect or inaccessible.
   * Anything the postprocessing script prints to stdout and stderr should be reflected in the terminal running simple-scan.

  [ Where problems could occur ]

   * Logic around saving has been changed, so there might be possible
  regressions when saving without postprocessing enabled, and this
  scenario should be tested.

  [ Other Info ]

   * This bug has already been fixed upstream, and the changes here are
  cherry-picked from there: https://gitlab.gnome.org/GNOME/simple-
  scan/-/merge_requests/290

  [ Original Description ]

  Release: Ubuntu 24.04.2 LTS

  Simple-scan version: 46.0-0ubuntu2

  When saving a file, simple-scan warns that the file cannot be saved, even though the file is actually saved.
  Then saving is proposed when I quit simple-scan and I have to quit without saving.

  It's not blocking, but it's annoying all the same.

  I found this answer that solves the problem: https://askubuntu.com/a/1411037
  So it seems like the problem is post-processing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/simple-scan/+bug/2112619/+subscriptions