debcrafters-packages team mailing list archive

[Frank Heimes <mp+490705@xxxxxxxxxxxxxxxxxx>]

Review: Approve

Hi John, many thanks for this piece of work,
and especially for the detailed instructions in 'Description of the change' - these are really helpful!

And the test build in PPA and the manual tests that you ran are also good and provide further confidence.
I had a look at the logs (at least for two architectures) and they look fine.

It was a bit difficult to handle the big diff for this version bump, but I was able to manage it outside of the browser.
I am barely able to verify all the diff parts that come from the version delta, but at least the Debian bits, and they looked good.

I noticed that you not only upgraded to the 3.25.1, but you also included the additional commit that was requested on top:
 * new upstream release (LP: #2116735)
 * d/p/support-z17-nnpa-instructions.patch: s390x:
   Support z17 changes to the NNPA. (LP: #2119288)
Which is great, since this covers everything that's needed for 25.10!
(Reading https://code.launchpad.net/~jchittum/ubuntu/+source/valgrind/+git/valgrind/+merge/490705/comments/1332631 I was unsure if the add. patch is in, but it is!)

Overall, well done and LGTM !

-- 
https://code.launchpad.net/~jchittum/ubuntu/+source/valgrind/+git/valgrind/+merge/490705
Your team Debcrafters packages is requested to review the proposed merge of ~jchittum/ubuntu/+source/valgrind:lp2116735-questing into ubuntu/+source/valgrind:ubuntu/devel.