debcrafters-packages team mailing list archive

[Chris Halse Rogers <2083867@xxxxxxxxxxxxxxxxxx>]

Could someone please verify this? We've had a quick look, and the
compile flags on amd64, arm64, and riscv64 do contain -fno-omit-frame-
pointer (as expected, s390x, ppc64el and armhf do not).

However, the final link is not done with -fno-omit-frame-pointer; due to
LTO we're not sure whether this actually leaves all the frame pointers
in.

The elf info is:
...
 <0><c>: Abbrev Number: 85 (DW_TAG_compile_unit)
    <d>   DW_AT_producer    : (indirect string, offset: 0x4a): GNU GIMPLE 13.3.0 -mno-omit-leaf-frame-pointer -mtune=generic -march=x86-64 -g -g -O2 -O2 -fno-openmp -fno-openacc -fcf-protection=full -fasynchronous-unwind-tables -fPIC -fstack-protector-strong -fltrans
...
 <0><4c03>: Abbrev Number: 34 (DW_TAG_compile_unit)
    <4c04>   DW_AT_producer    : (indirect string, offset: 0x6cf): GNU C17 13.3.0 -mno-omit-leaf-frame-pointer -mtune=generic -march=x86-64 -g -O2 -fvisibility=hidden -fno-omit-frame-pointer -flto -ffat-lto-objects -fstack-protector-strong -fcf-protection=full -fPIC -fasynchronous-unwind-tables -fstack-protector-strong -fstack-clash-protection

-- 
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to xserver-xorg-video-vesa in
Ubuntu.
https://bugs.launchpad.net/bugs/2083867

Title:
   [SRU] Please enable frame-pointer for xserver-xorg-video-vesa on
  Noble

Status in xserver-xorg-video-vesa package in Ubuntu:
  Fix Released
Status in xserver-xorg-video-vesa source package in Noble:
  Fix Committed

Bug description:
  [Impact]

  In order to help developers with profiling, Ubuntu enabled frame-
  pointers for packages in the main archive.

  https://ubuntu.com/blog/ubuntu-performance-engineering-with-frame-
  pointers-by-default

  The `Affects` packages were missed due to the packaging issues. These
  have been fixed on Oracular and can now be ported to Noble.

  [Test Plan]

  Look at the DW_AT_producer in the associated debug ELF file for flags.
  -fno-omit-frame-pointer should be present after the fix.

  The following scripts can be used as a reference
  https://gist.github.com/julian-klode/85e55553f85c410a1b856a93dce77208
  https://gist.github.com/julian-klode/95818246eaef0ac6a54588f7f368e25c

  You can also check the build logs for build flags like `-fno-omit-
  frame-pointer`.

  [Where problems could occur]

  * A distribution-specific patch was applied to fix the build with security hardening flags enabled.
  * The packaging fixes have enabled other security hardening flags. This could have unintended effects.

  [Other Info]

  changes in dpkg have been made to make sure frame-pointers are not
  enabled on s390x and ppc64el.

  Bug reference with similar SRU -
  https://bugs.launchpad.net/ubuntu/+source/ipvsadm/+bug/2071949

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-vesa/+bug/2083867/+subscriptions