debcrafters-packages team mailing list archive

[Launchpad Bug Tracker <2062159@xxxxxxxxxxxxxxxxxx>]

This bug was fixed in the package xserver-xorg-video-vesa -
1:2.6.0-1ubuntu0.1

---------------
xserver-xorg-video-vesa (1:2.6.0-1ubuntu0.1) noble; urgency=medium

  * d/p/fix-implicit-declarations.patch: patching the file to fix FTBFS
    on multiple platforms (LP: #2062159).
  * Rebuild to pick-up debhelper frame-pointer flags (LP: #2083867).

 -- Zixing Liu <zixing.liu@xxxxxxxxxxxxx>  Mon, 01 Jul 2024 15:09:55
-0600

** Changed in: xserver-xorg-video-vesa (Ubuntu Noble)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to xserver-xorg-video-vesa in
Ubuntu.
https://bugs.launchpad.net/bugs/2062159

Title:
  xserver-xorg-video-vesa 1:2.6.0-1build1 FTBFS on armhf

Status in xserver-xorg-video-vesa package in Ubuntu:
  Fix Released
Status in xserver-xorg-video-vesa source package in Noble:
  Fix Released
Status in xserver-xorg-video-vesa source package in Oracular:
  Fix Released

Bug description:
  [Impact]

  xserver-xorg-video-vesa 1:2.6.0-1build1 fails to build on armhf.
  Relevant log:

  ```
  libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../src -I.. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=3 -I/usr/include/xorg -fvisibility=hidden -I/usr/include/pixman-1 -I/usr/include/X11/dri -I/usr/include/libdrm -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fno-stack-clash-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/xserver-xorg-video-vesa-1:2.6.0-1build1 -c ../../src/vesa.c  -fPIC -DPIC -o .libs/vesa.o
  ../../src/vesa.c: In function ‘VESALoadPalette’:
  ../../src/vesa.c:1437:12: error: implicit declaration of function ‘outb’ [-Werror=implicit-function-declaration]
   1437 |            outb(pVesa->ioBase + VGA_DAC_WRITE_ADDR, idx);
        |            ^~~~
  ../../src/vesa.c:1431:18: error: implicit declaration of function ‘inb’ [-Werror=implicit-function-declaration]
   1431 |            (void)inb(pVesa->ioBase + VGA_IOBASE_COLOR + VGA_IN_STAT_1_OFFSET); \
        |                  ^~~
  ../../src/vesa.c:1438:12: note: in expansion of macro ‘VESADACDelay’
   1438 |            VESADACDelay();
        |            ^~~~~~~~~~~~
  ```

  [Test Plan]

  The package needs to build.

  [Where problems could occur]

  Declaring the function prototypes for un-exposed functions may cause
  memory safety issues should the API change. This was already a risk in
  an existing driver code that used a function without a declared
  prototype.

  [Other Info]

  n/a

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-vesa/+bug/2062159/+subscriptions