deja-dup-team team mailing list archive

[Andrew Fister <temposs@xxxxxxxxx>]

The code is ready for another looking over :-)

-Andrew

On Sun, Sep 6, 2009 at 10:26 PM, Michael Terry
<michael.terry@xxxxxxxxxxxxx>wrote:

> > var native_path = true;
> >   try {
> >     var client = GConf.Client.get_default();
> >     var backend_name = client.get_string(DejaDup.BACKEND_KEY);
> >
> >     if (backend_name == "s3")
> >       native_path = false;
> >     else if (backend_name == "file")
> >     {
> >       var path = DejaDup.BackendFile.get_location_from_gconf();
> >       var backend_file = File.parse_name(path);
> >       native_path = backend_file.is_native();
> >     }
> >   }
> >
> > What do you think of this?
>
> Note that while get_default() does take a Window argument, it is
> "Gtk.Window? win" -- the question mark means it's optional.  You can just
> pass "null".
>
> But truthfully, though I don't like the duplication of code, it's probably
> worth it here if it means dropping the libdeja-dup dependency.  Backends
> don't get added everyday.  We can either separate out parts of libdeja-dup
> later or just deal with the duplication.  This would let us merely add dbus
> as a dependency to the monitor.
>
> You can leave the translation changes in, just as long as I can drop them
> when I merge (i.e. I don't have to pick out meaningful changes from
> non-meaningful).  I don't think you made any changes to user strings.  And
> the whitespace stuff is fine too.
> --
>
> https://code.edge.launchpad.net/~temposs/deja-dup/network-manager/+merge/11123<https://code.edge.launchpad.net/%7Etemposs/deja-dup/network-manager/+merge/11123>
> You are the owner of lp:~temposs/deja-dup/network-manager.
>

-- 
https://code.launchpad.net/~temposs/deja-dup/network-manager/+merge/11123
Your team Déjà Dup Maintainers is subscribed to branch lp:deja-dup.