← Back to team overview

deja-dup-team team mailing list archive

Re: [Merge] lp:~chogydan/deja-dup/show-password into lp:deja-dup

 

Review: Approve
Looks great, thank you!  I made a minor modification to simplify it:

+ if(button.get_active())
+ encrypt_entry.set_visibility(true);
+ else
+ encrypt_entry.set_visibility(false);

became:

+ encrypt_entry.visibility = button.get_active();

I also copy+pasted the snippet into the remote-server password code in MountOperationAssistant.vala.
-- 
https://code.edge.launchpad.net/~chogydan/deja-dup/show-password/+merge/19562
Your team Déjà Dup Maintainers is subscribed to branch lp:deja-dup.



References