deja-dup-team team mailing list archive

[Michael Terry <michael.terry@xxxxxxxxxxxxx>]

Looks like you can drop changes in common/OperationRestore.vala.
There are warnings in AssistantDirectoryHistory about unused variables.
Drop the "stdout.printf("\n\ndirhistmode\n\n"); line.

The interface files need some extra support.  They should be moved to a subdirectory of data/ and added to data/Makefile.am, to be installed in pkgdatadir.  Then they should be searched for in g_get_system_data_dirs().  And finally, the testing framework needs to be able to find them in the local directory (just by adjusting XDG_DATA_DIRS if it doesn't already).

When testing, I'm seeing some errors like:

(deja-dup:10259): Gtk-CRITICAL **: IA__gtk_icon_theme_load_icon: assertion `icon_name != NULL' failed

** (deja-dup:10262): CRITICAL **: deja_dup_operation_continue_with_passphrase: assertion `self != NULL' failed

This second one, you were able to fix by commenting out that continue_with_passphrase line.  But something is wrong if that's the fix.  I think you should look at why continue_with_passphrase is being called on a null instance.

I'd like --dir-history renamed to --restore-missing, so it's clear that it's about restoring and what it restores.

I'm OK with leaving "Done!", but let's rename it to "Scanning finished" or something equally boring.

About "this.op = null" vs "op = null", it was an issue because there was also a local variable (in the function arguments) called "op".  So "op" refers to the local variable, and "this.op" to the class variable.

I'd still like to see a test (that handles both missing files and missing folders) added for this feature to the test suite.  And we still need nautilus UI for it.  Those can come after the above fixes though.

And remember to add yourself to the About dialog (MainWindow.vala) and the AUTHORS file.
-- 
https://code.launchpad.net/~urbans/deja-dup/deja-dup.nautilus/+merge/29723
Your team Déjà Dup Maintainers is subscribed to branch lp:deja-dup.