deja-dup-team team mailing list archive

[throughnothing <throughnothing@xxxxxxxxx>]

throughnothing has proposed merging lp:deja-dup into lp:~throughnothing/deja-dup/include_exclude_files.

Requested reviews:
  Michael Terry (mterry)
Related bugs:
  #481582 Single-file restore downloads whole backup
  https://bugs.launchpad.net/bugs/481582
  #486662 Ignores include directories with a symlink in the path
  https://bugs.launchpad.net/bugs/486662
  #539304 Use a nicer message when backup destination does not exist
  https://bugs.launchpad.net/bugs/539304
  #540590 Add a 'restore missing files' view
  https://bugs.launchpad.net/bugs/540590
  #578090 cannot work with global-menu
  https://bugs.launchpad.net/bugs/578090
  #578663 Use log codes for common backend errors
  https://bugs.launchpad.net/bugs/578663
  #580850 Use nicer message when no space left in backup location
  https://bugs.launchpad.net/bugs/580850
  #582720 GPG EOFError during restore
  https://bugs.launchpad.net/bugs/582720
  #590133 [data-loss] Trying to keep backups 'forever' ends up keeping backups 6 months
  https://bugs.launchpad.net/bugs/590133
  #599632 Deja Dup won't run without Network Manager loaded
  https://bugs.launchpad.net/bugs/599632
  #617012 DBus error org.gtk.Private.RemoteVolumeMonitor.Failed: An operation is already pending
  https://bugs.launchpad.net/bugs/617012
  #631517 if symlink is exclude list, target is marked as include
  https://bugs.launchpad.net/bugs/631517
  #632612 [PATCH] add GTK requirement to some modules
  https://bugs.launchpad.net/bugs/632612
  #657518 If free space is not reported, Deja Dup assumes zero
  https://bugs.launchpad.net/bugs/657518
  #662884 Déjà Dup requests root privileges when I try to restore a backup
  https://bugs.launchpad.net/bugs/662884
  #668160 drop status icon use for GNOME 3
  https://bugs.launchpad.net/bugs/668160
  #668357 Don't scan folders if only an incremental backup
  https://bugs.launchpad.net/bugs/668357
  #674388 Deja dup crashes on trying to change backup target
  https://bugs.launchpad.net/bugs/674388

For more details, see:
https://code.launchpad.net/~deja-dup-team/deja-dup/trunk/+merge/51849

This is my first time working with vala, and my first time poking around with deja-dup, so I'm sure this change is far from perfect (and maybe not the best way to do this?), but It essentially just replaces the "Add" buttons on the "Files" tab of the preferences dialog with "Add File" and "Add Folder" buttons for both the include and exclude ConfigLists.

I realized this would work when I saw that it was already just adding an --include and --exclude flag for each item in the list, so files or folders would pass through just fine.

Of course, I'm not sure if this is the best UI for this, as it does add an extra button, and thus some added complexity. 

Let me know your thoughts, any comments/suggestions greatly appreciated.  I look forward to doing more with deja-dup in the future :) 
-- 
https://code.launchpad.net/~deja-dup-team/deja-dup/trunk/+merge/51849
Your team Déjà Dup Maintainers is subscribed to branch lp:deja-dup.