deja-dup-team team mailing list archive

[Jim Campbell <jcampbell@xxxxxxxxx>]

> 100     +  <title type="link">Backup Help</title>
> 101     +    <title type="text">Backup Help</title>
> 
> This is duplicated, I assume accidentally.

The repetition is intentional. See here for further information: http://projectmallard.org/1.0/mal_info_title

This approach is used in gnome-user-docs, gedit, file-roller, the draft seahorse help, and other gnome help.

> 
> 111     +    <media type="image" mime="image/png" src="figures/deja-dup-
> icon.png">
> 112     +    </media>
> 
> This doesn't seem well-centered in my tests.  Plus, none of the other GNOME
> apps seem to use an icon.  I'm inclined to drop this change.

I'm using the same approach as used in gedit, gnome-help, ubuntu help, seahorse (aka passwords and keys), gnome-terminal, and the other gnome applications will be getting their appropriate icon in this manner in the near future. I see what you mean about it not lining up exactly right - not sure what I can do about it, as the alignment is handled by the yelp stylesheets. 

Thanks for being so thorough in your review. Let me know if you have other fixes you'd like me to make. 
-- 
https://code.launchpad.net/~jwcampbell/deja-dup/deja-dup-doc-updates/+merge/170892
Your team Déjà Dup Developers is subscribed to branch lp:deja-dup.